Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for computed values of width with calc() range checks #9574

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@astearns
Copy link
Contributor

astearns commented Feb 19, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 19, 2018

Build ERRORED

Started: 2018-02-19 23:14:54
Finished: 2018-02-19 23:24:50

Failing Jobs

  • lint
  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/css/css-values/clamp-width-up.html   TIMEOUT: 4
OK: 6
  CSS Values and Units: Range checking clamped values PASS: 10
FAIL: 6
assert_equals: expected "0px" but got "50px"
async_test(function(t) {
testDiv.setAttribute("class", "test");
setTimeout('clampedWidth = checkWidth();', 1500);

This comment has been minimized.

Copy link
@FremyCompany

FremyCompany Feb 21, 2018

Contributor

Instead of setTimeout and step_timeout that are deprecated (and do cause trouble) may I suggest relying on animation-delay to be able to check the correct values in a simple requestAnimationFrame from the get go?

This comment has been minimized.

Copy link
@astearns

astearns May 1, 2018

Author Contributor

@FremyCompany Is the latest commit what you meant? This seems to work when the tests pass, but when they fail I see an uncaught exception as well as the testharness failure.

}, 2000);
})
</script>
<!DOCTYPE html>

This comment has been minimized.

Copy link
@FremyCompany

FremyCompany Feb 21, 2018

Contributor

doctype x2

}, 1000);
})
</script>
<!DOCTYPE html>

This comment has been minimized.

Copy link
@FremyCompany

FremyCompany Feb 21, 2018

Contributor

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.