Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Make sure implementation IDL matches spec IDL. #9581

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 20, 2018

This patch updates our IDL to match that of the spec. We found two
issues in the process:

  • StylePropertyMap.get should return (undefined or CSSStyleValue),
    but IDL doesn't provide that yet. The spec uses "any" as a workaround
    but we'll return (null or CSSStyleValue) for now (null vs undefined).
    We'll change the code once IDL gives us something for this.
  • Iteration should always return a sequence of CSSStyleValue, whereas
    they used to return either CSSStyleValue or sequence of CSSStyleValues
    depending on whether the property was list valued or not.

We change the code to fix this.

We deleted the inlineStylePropertyMap_iteration.html LayoutTest
as it is already covered by WPT.

We also update the WPT test expectations to match the spec.

Bug: 812915
Change-Id: Id2f9fbba4398c9ecfd63ea3f8e1aad0b3a0b499f
Reviewed-on: https://chromium-review.googlesource.com/925981
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#538367}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-925981 branch from 2535df6 to a70b729 Feb 20, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 20, 2018

Build PASSED

Started: 2018-02-22 07:06:48
Finished: 2018-02-22 07:13:11

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-925981 branch 2 times, most recently from 124a89e to cd95431 Feb 20, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-925981 branch 7 times, most recently from 8d2e099 to 9ffbe40 Feb 20, 2018

[css-typed-om] Make sure implementation IDL matches spec IDL.
This patch updates our IDL to match that of the spec. We found two
issues in the process:
- StylePropertyMap.get should return (undefined or CSSStyleValue),
  but IDL doesn't provide that yet. The spec uses "any" as a workaround
  but we'll return (null or CSSStyleValue) for now (null vs undefined).
  We'll change the code once IDL gives us something for this.
- Iteration should always return a sequence of CSSStyleValue, whereas
  they used to return either CSSStyleValue or sequence of CSSStyleValues
  depending on whether the property was list valued or not.

We change the code to fix this.

We deleted the inlineStylePropertyMap_iteration.html LayoutTest
as it is already covered by WPT.

We also update the WPT test expectations to match the spec.

Bug: 812915
Change-Id: Id2f9fbba4398c9ecfd63ea3f8e1aad0b3a0b499f
Reviewed-on: https://chromium-review.googlesource.com/925981
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538367}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-925981 branch from 9ffbe40 to 71077f8 Feb 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 53a527f into master Feb 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-925981 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.