Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that document.importNode() doesn't clone Attr nodes with namespace. #9582

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 20, 2018

We should just call Attr::Clone().

Bug: 812089, 812105
Change-Id: I163769e134a52d82b88834ae29083a01a3480e95
Reviewed-on: https://chromium-review.googlesource.com/925865
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#537730}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 20, 2018

Build PASSED

Started: 2018-02-20 07:21:50
Finished: 2018-02-20 07:29:58

View more information about this build on:

Fix a bug that document.importNode() doesn't clone Attr nodes with na…
…mespace.

We should just call Attr::Clone().

Bug: 812089, 812105
Change-Id: I163769e134a52d82b88834ae29083a01a3480e95
Reviewed-on: https://chromium-review.googlesource.com/925865
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537730}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-925865 branch from 5f000a2 to a5917e1 Feb 20, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a5a46d4 into master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-925865 branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.