Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "dtmf" attribute on RTCRTPSender #9583

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 20, 2018

This brings the API into conformance with the spec:
https://w3c.github.io/webrtc-pc/#dom-rtcdtmfsender

The CL also exposes the RTCDTMFToneChange event, which
was previously marked [ NoInterface ].

Bug: 812587
Change-Id: I4122d1e4e336b811de234ed492f0de02dcc7a714
Reviewed-on: https://chromium-review.googlesource.com/926181
Reviewed-by: Guido Urdaneta guidou@chromium.org
Reviewed-by: Henrik Boström hbos@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Commit-Queue: Harald Alvestrand hta@chromium.org
Cr-Commit-Position: refs/heads/master@{#538782}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 20, 2018

Build PASSED

Started: 2018-02-23 15:26:27
Finished: 2018-02-23 15:33:20

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/webrtc/RTCDTMFSender-insertDTMF.https.html   TIMEOUT: 4
OK: 6
  insertDTMF() should set toneBuffer to provided tones normalized, with old tones overridden FAIL: 6
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  insertDTMF() should succeed if tones contains valid DTMF characters FAIL: 6
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  insertDTMF() should throw InvalidCharacterError if tones contains invalid DTMF characters FAIL: 6
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"
  insertDTMF() should throw InvalidStateError if transceiver.currentDirection is inactive FAIL: 6
assert_equals: expected (string) "inactive" but got (undefined) undefined
  insertDTMF() should throw InvalidStateError if transceiver.currentDirection is recvonly FAIL: 6
assert_equals: expected (string) "inactive" but got (undefined) undefined
  insertDTMF() should throw InvalidStateError if transceiver is stopped FAIL: 6
assert_throws: function "() => dtmfSender.insertDTMF('')" threw object "TypeError: undefined is not an object (evaluating 'dtmfSender.insertDTMF')" that is not a DOMException InvalidStateError: property "code" is equal to undefined, expected 11

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-926181 branch 5 times, most recently from 2f33b15 to 8230669 Feb 21, 2018

Add the "dtmf" attribute on RTCRTPSender
This brings the API into conformance with the spec:
https://w3c.github.io/webrtc-pc/#dom-rtcdtmfsender

The CL also exposes the RTCDTMFToneChange event, which
was previously marked [ NoInterface ].

Bug: 812587
Change-Id: I4122d1e4e336b811de234ed492f0de02dcc7a714
Reviewed-on: https://chromium-review.googlesource.com/926181
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538782}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-926181 branch from 8230669 to c8b8f9b Feb 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 580021b into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-926181 branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.