Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Update feature policy default allowlist to *. #9584

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 20, 2018

This CL reflects updated spec which changes Picture-in-Picture feature
to be allowed by default to documents in child frames.

Bug: 806249
Change-Id: I7c7a3a073b30ad5118aa634b0c0b1f3ac60d2e7a
Reviewed-on: https://chromium-review.googlesource.com/926104
Reviewed-by: Mounir Lamouri mlamouri@chromium.org
Reviewed-by: Ian Clelland iclelland@chromium.org
Commit-Queue: Mounir Lamouri mlamouri@chromium.org
Cr-Commit-Position: refs/heads/master@{#538145}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 20, 2018

Build PASSED

Started: 2018-02-21 19:03:04
Finished: 2018-02-21 19:10:47

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/feature-policy/picture-in-picture-default-feature-policy.https.sub.html   TIMEOUT: 1
ERROR: 9
  Default "picture-in-picture" feature policy [*] allows cross-origin iframes. TIMEOUT: 9
Test timed out
  Default "picture-in-picture" feature policy [*] allows same-origin iframes. TIMEOUT: 9
Test timed out
  Default "picture-in-picture" feature policy [*] allows the top-level document. TIMEOUT: 9
Test timed out
[Picture-in-Picture] Update feature policy default allowlist to *.
This CL reflects updated spec which changes Picture-in-Picture feature
to be allowed by default to documents in child frames.

Bug: 806249
Change-Id: I7c7a3a073b30ad5118aa634b0c0b1f3ac60d2e7a
Reviewed-on: https://chromium-review.googlesource.com/926104
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538145}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-926104 branch from f7b424a to d81bf0a Feb 21, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit aeda1ba into master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-926104 branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.