Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createElement()/createElementNS() dictionary argument can be a string #9586

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@annevk
Copy link
Member

annevk commented Feb 20, 2018

Helps with whatwg/dom#572.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 20, 2018

Build PASSED

Started: 2018-02-20 15:04:06
Finished: 2018-02-20 15:27:24

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Feb 24, 2018

@domenic can you review this as well?

@annevk annevk merged commit 2a181b3 into master Feb 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/createelement-string branch Feb 26, 2018

annevk added a commit to whatwg/dom that referenced this pull request Feb 26, 2018

createElement/createElementNS()'s dictionary argument can be a string
For compatibility with deployed content, when a string is passed rather than a dictionary, simply ignore the string rather than throw.

Tests: web-platform-tests/wpt#9586.

Fixes w3c/webcomponents#544.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.