Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8954: update wptrunner requirements #9587

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
5 participants
@gsnedders
Copy link
Contributor

gsnedders commented Feb 20, 2018

Note this just uses the current stable release of all dependencies rather than trying to find what the minimum required actually is.

Fixes #8954.


This change is Reviewable

Fix #8954: update wptrunner requirements
Note this just uses the current stable release of all dependencies
rather than trying to find what the minimum required actually is.

@wpt-pr-bot wpt-pr-bot added the infra label Feb 20, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Feb 20, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Feb 20, 2018

I wonder if we should just use == versions, or if we should get tox to test minimum requirements. Given we're an actual application, using == probably makes more sense.

Pin wptrunner dependencies
Given it's an application, we should just define the environment we
expect it to run in. This should stop #8954 from regressing, given it
also means we'll be testing against the only possible set of versions
of our dependencies.
@kereliuk

This comment has been minimized.

Copy link
Contributor

kereliuk commented Feb 20, 2018

My personal taste is to prefer == to > unless there is a good reason. So I am all for == :)

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 20, 2018

Build PASSED

Started: 2018-02-20 15:43:37
Finished: 2018-02-20 16:02:39

View more information about this build on:

@jgraham jgraham merged commit d936893 into web-platform-tests:master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:wptrunner-requirements branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.