Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc Add https://streams.spec.whatwg.org/demos tests #9596

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@sideshowbarker
Copy link
Member

sideshowbarker commented Feb 21, 2018

When JavaScript-syntax checking for script-element contents was
recently added to the HTML checker, it broke the build of the Streams
spec due to some documents in https://streams.spec.whatwg.org/demos/
using some newer JavaScript syntax that the Rhino parser (which the HTML
checker relies on) doesn’t understand yet.

So to ensure those cases get handled correctly, some refinements were
made to the HTML checker and the Rhino fork it uses. The documents are
added here to ensure no regressions occur.

Thanks @domenic

cc Add https://streams.spec.whatwg.org/demos tests
When JavaScript-syntax checking for `script`-element contents was
recently added to the HTML checker, it broke the build of the Streams
spec due to some documents in https://streams.spec.whatwg.org/demos/
using some newer JavaScript syntax that the Rhino parser (which the HTML
checker relies on) doesn’t understand yet.

So to ensure those cases get handled correctly, some refinements were
made to the HTML checker and the Rhino fork it uses. The documents are
added here to ensure no regressions occur.
@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Feb 21, 2018

There are no owners for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-21 08:17:51
Finished: 2018-02-21 08:22:33

View more information about this build on:

@sideshowbarker sideshowbarker merged commit 46c5f2b into master Feb 21, 2018

1 of 2 checks passed

pyup.io/safety-ci html5lib 0.9999999 has known security vulnerabilities.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sideshowbarker sideshowbarker deleted the sideshowbarker/cc-streams-demos-regression branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.