Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ES6 constructs from pages used in WebDriver tests #9600

Merged
merged 3 commits into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@jimevans
Copy link
Contributor

jimevans commented Feb 21, 2018

Internet Explorer doesn't support ES6 constructs like fat arrow functions.
So that the WebDriver tests can be executed against IE, the pages loaded
in the browser by the tests shouldn't include such constructs.

Removing ES6 constructs from pages used in WebDriver tests
Internet Explorer doesn't support ES6 constructs like fat arrow functions.
So that the WebDriver tests can be executed against IE, the pages loaded
in the browser by the tests shouldn't include such constructs.
});
}
</script>
""")
three, two, one = session.find.css("div")
one.click()

delayed_clicks = session.execute_script("return window.delayedClicks")
delayed_clicks = session.execute_script("return window.delayedClicks;")

This comment has been minimized.

Copy link
@andreastt

andreastt Feb 21, 2018

Member

FWIW the semicolon shouldn’t be necessary as the injected script is wrapped in a function, and semicolons aren’t required in JS.

This comment has been minimized.

Copy link
@jimevans

jimevans Feb 21, 2018

Author Contributor

Reverted to previous syntax, without semicolons.

@@ -1,6 +1,6 @@
from tests.support.asserts import assert_success
from tests.support.inline import inline

from time import sleep

This comment has been minimized.

Copy link
@andreastt

andreastt Feb 21, 2018

Member

Unused?

This comment has been minimized.

Copy link
@jimevans

jimevans Feb 21, 2018

Author Contributor

D'oh! Fixed in another commit.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-21 15:50:20
Finished: 2018-02-21 16:00:36

Failing Jobs

  • chrome:dev

View more information about this build on:

@andreastt andreastt merged commit d6dc97a into web-platform-tests:master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jimevans jimevans deleted the jimevans:bubbling branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.