From 82f2937da2dcedc521cba5c2acc32698a18503df Mon Sep 17 00:00:00 2001 From: Jim Evans Date: Wed, 21 Feb 2018 07:08:34 -0800 Subject: [PATCH 1/3] Removing ES6 constructs from pages used in WebDriver tests Internet Explorer doesn't support ES6 constructs like fat arrow functions. So that the WebDriver tests can be executed against IE, the pages loaded in the browser by the tests shouldn't include such constructs. --- webdriver/tests/element_click/bubbling.py | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/webdriver/tests/element_click/bubbling.py b/webdriver/tests/element_click/bubbling.py index 1cfb2efa2f5563..29925be97ff6a4 100644 --- a/webdriver/tests/element_click/bubbling.py +++ b/webdriver/tests/element_click/bubbling.py @@ -1,6 +1,6 @@ from tests.support.asserts import assert_success from tests.support.inline import inline - +from time import sleep def click(session, element): return session.transport.send( @@ -28,9 +28,10 @@ def test_click_event_bubbles_to_parents(session): @@ -38,7 +39,7 @@ def test_click_event_bubbles_to_parents(session): three, two, one = session.find.css("div") one.click() - clicks = session.execute_script("return window.clicks") + clicks = session.execute_script("return window.clicks;") assert one in clicks assert two in clicks assert three in clicks @@ -67,9 +68,11 @@ def test_spin_event_loop(session): @@ -77,7 +80,7 @@ def test_spin_event_loop(session): three, two, one = session.find.css("div") one.click() - delayed_clicks = session.execute_script("return window.delayedClicks") + delayed_clicks = session.execute_script("return window.delayedClicks;") assert one in delayed_clicks assert two in delayed_clicks assert three in delayed_clicks From d71bfaccf7112c57fd5bf5252b79f048b1f2afab Mon Sep 17 00:00:00 2001 From: Jim Evans Date: Wed, 21 Feb 2018 07:23:36 -0800 Subject: [PATCH 2/3] Removing unused import --- webdriver/tests/element_click/bubbling.py | 1 - 1 file changed, 1 deletion(-) diff --git a/webdriver/tests/element_click/bubbling.py b/webdriver/tests/element_click/bubbling.py index 29925be97ff6a4..f504bc3f9cf430 100644 --- a/webdriver/tests/element_click/bubbling.py +++ b/webdriver/tests/element_click/bubbling.py @@ -1,6 +1,5 @@ from tests.support.asserts import assert_success from tests.support.inline import inline -from time import sleep def click(session, element): return session.transport.send( From 20faa4e08e9c130bb6d9e1383aae6cfd3f7c2721 Mon Sep 17 00:00:00 2001 From: Jim Evans Date: Wed, 21 Feb 2018 07:27:11 -0800 Subject: [PATCH 3/3] Removing unnecessary semicolons --- webdriver/tests/element_click/bubbling.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webdriver/tests/element_click/bubbling.py b/webdriver/tests/element_click/bubbling.py index f504bc3f9cf430..7bf405c76f7efc 100644 --- a/webdriver/tests/element_click/bubbling.py +++ b/webdriver/tests/element_click/bubbling.py @@ -38,7 +38,7 @@ def test_click_event_bubbles_to_parents(session): three, two, one = session.find.css("div") one.click() - clicks = session.execute_script("return window.clicks;") + clicks = session.execute_script("return window.clicks") assert one in clicks assert two in clicks assert three in clicks @@ -79,7 +79,7 @@ def test_spin_event_loop(session): three, two, one = session.find.css("div") one.click() - delayed_clicks = session.execute_script("return window.delayedClicks;") + delayed_clicks = session.execute_script("return window.delayedClicks") assert one in delayed_clicks assert two in delayed_clicks assert three in delayed_clicks