Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional enabled <option> element in WebDriver test page #9601

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@jimevans
Copy link
Contributor

jimevans commented Feb 21, 2018

Clicking on a disabled element should not allow it to become
selected. However, if the disabled is the only child element of
the element, it may be marked as selected by the user agent. This commit allows the test to attempt to call elementClick on a disabled without it being selected.

Adding additional enabled <option> element in WebDriver test page
Clicking on a disabled <option> element should not allow it to become
selected. However, if the disabled <option> is the only child element of
the <select> element, it may be marked as selected by the user agent. This
commit allows the test to attempt to call elementClick on a disabled
<option> without it being selected.
@andreastt

This comment has been minimized.

Copy link
Member

andreastt commented Feb 21, 2018

Is that what HTML says? That the selected option of <select disabled> can be the first if there are two or more <option>s? Or is this working around a defect in IE?

@jimevans

This comment has been minimized.

Copy link
Contributor Author

jimevans commented Feb 21, 2018

I'm not entirely sure. Bear in mind, though, that we're not doing <select disabled>. What we have is <select><option disabled></select>.

@andreastt

This comment has been minimized.

Copy link
Member

andreastt commented Feb 21, 2018

Hm OK. I somewhat suspect this is working around an IE specific bug, but it doesn’t really matter since we’re testing WebDriver and having an additional <option> isn’t going to cause problems for other WebDriver imeplemtations.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-21 15:22:27
Finished: 2018-02-21 15:38:02

Failing Jobs

  • chrome:dev

View more information about this build on:

@andreastt andreastt merged commit cf1569d into web-platform-tests:master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jimevans jimevans deleted the jimevans:select branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.