Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS build system requirements #9602

Merged

Conversation

Projects
None yet
6 participants
@gsnedders
Copy link
Contributor

gsnedders commented Feb 21, 2018

Fixes #7200 (comment).

This cannot be merged until https://lists.w3.org/Archives/Public/public-css-testsuite/2018Feb/0001.html has landed in w3ctestlib and then this should be amended so that the w3ctestlib submodule is updated before the requirements update.

cc/ @jgraham @foolip

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Feb 21, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@gsnedders gsnedders requested a review from jgraham Feb 21, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-26 21:34:06
Finished: 2018-02-26 21:52:47

View more information about this build on:

@@ -2,11 +2,11 @@
set -ex

SCRIPT_DIR=$(dirname $(readlink -f "$0"))

This comment has been minimized.

Copy link
@gsnedders

gsnedders Feb 21, 2018

Author Contributor

This is broken because somehow on CI "$0" is actually tools/ci/run.sh o_O

This comment has been minimized.

Copy link
@gsnedders

gsnedders Feb 26, 2018

Author Contributor

Should be fixed now?

@gsnedders gsnedders force-pushed the gsnedders:css-build-system-update branch from 6ab0f17 to e1bc90a Feb 21, 2018

@wpt-pr-bot wpt-pr-bot requested review from kojiishi and plinss Feb 21, 2018

@Ms2ger

This comment has been minimized.

Copy link
Contributor

Ms2ger commented Feb 22, 2018

Causes issues like ./tools/ci/run.sh: line 9: tools/ci/ci_lint.sh: Permission denied

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 23, 2018

What's w3ctestlib and why is it maintained with patches on a mailing list? :)

@plinss

This comment has been minimized.

Copy link
Contributor

plinss commented Feb 23, 2018

w3ctestlib is part of the csswg test suite build system (which predates wpt by many years), it's still in use by the csswg test harness.

The primary repo for w3ctestlib is on the csswg's mercurial server but there is a mirror on github: https://github.com/w3c/csswg-w3ctestlib

Changes to w3ctestlib do need to get upstreamed to the mercurial repo for the csswg infrastructure to get them, hence the patch sent to me, but a PR to the github repo also would have worked (and in a pinch, would have unblocked wpt).

@gsnedders gsnedders force-pushed the gsnedders:css-build-system-update branch from e1bc90a to 4d6e040 Feb 26, 2018

@gsnedders gsnedders force-pushed the gsnedders:css-build-system-update branch from bbb18a1 to 7e8ff84 Feb 26, 2018

@gsnedders gsnedders force-pushed the gsnedders:css-build-system-update branch from 7e8ff84 to 99ba27c Feb 26, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Feb 26, 2018

OK, this should be ready to land now. See https://travis-ci.org/w3c/web-platform-tests/builds/346437609 for all test jobs being run.

@Ms2ger

Ms2ger approved these changes Feb 27, 2018

@gsnedders gsnedders merged commit 1305210 into web-platform-tests:master Feb 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:css-build-system-update branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.