Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making test_handle_prompt_accept consistent with other similar tests #9612

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@jimevans
Copy link
Contributor

jimevans commented Feb 21, 2018

Other webdriver tests that test the same thing for other commands all test
for accepting a prompt() dialog to look for either the empty string ("")
or undefined as the value returned by the method. This makes the
fullscreen tests consistent with those others.

Making test_handle_prompt_accept consistent with other similar tests
Other webdriver tests that test the same thing for other commands all test
for accepting a `prompt()` dialog to look for either the empty string ("")
or undefined as the value returned by the method. This makes the
fullscreen tests consistent with those others.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-21 21:13:48
Finished: 2018-02-21 21:45:10

Failing Jobs

  • chrome:dev

View more information about this build on:

@@ -85,7 +85,7 @@ def test_handle_prompt_accept(new_session, add_browser_capabilites):
response = fullscreen(session)

assert_dialog_handled(session, "accept #3")
assert read_global(session, "accept3") == ""
assert read_global(session, "accept3") == "" or read_global(session, "accept3") == "undefined"

This comment has been minimized.

Copy link
@andreastt

andreastt Feb 21, 2018

Member

This is fine, but for future reference this is more idiomatic:

assert read_global(session, "accept3") in ("", "undefined")

@andreastt andreastt merged commit e925327 into web-platform-tests:master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jimevans jimevans deleted the jimevans:fullscreen branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.