Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webauthn: support the appid extension. #9613

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 21, 2018

This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.

The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.

I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.

[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] w3c/webauthn#803

Bug: none
Change-Id: I22819adda99fbef9f10d38e797d08691dab7545d
Reviewed-on: https://chromium-review.googlesource.com/920659
Reviewed-by: Robert Sesek rsesek@chromium.org
Reviewed-by: Balazs Engedy engedy@chromium.org
Reviewed-by: Reilly Grant reillyg@chromium.org
Reviewed-by: Kim Paulhamus kpaulhamus@chromium.org
Cr-Commit-Position: refs/heads/master@{#539584}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-27 23:57:35
Finished: 2018-02-28 00:04:37

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-920659 branch 6 times, most recently from b290d26 to 3906eec Feb 22, 2018

webauthn: support the appid extension.
This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.

The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.

I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.

[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] w3c/webauthn#803

Bug: none
Change-Id: I22819adda99fbef9f10d38e797d08691dab7545d
Reviewed-on: https://chromium-review.googlesource.com/920659
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539584}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-920659 branch from 3906eec to acea3a5 Feb 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a200a0f into master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-920659 branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.