Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add unsupported tests for color properties. #9614

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 21, 2018

For color properties, we support 'currentcolor' as a CSSKeywordValue,
but any other value (including identifiers like 'red') are not supported
and are converted to base CSSStyleValues.

We add tests for most color related properties. We are failing the
text-emphasis-color one because we haven't unprefixed it yet.

We change the code to make this work.

Bug: 774887
Change-Id: Ide5463b9f67b63568ff32bd34e977faf16964bc1
Reviewed-on: https://chromium-review.googlesource.com/927943
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#538668}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-927943 branch from 1191341 to bf3bfd0 Feb 21, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 21, 2018

Build PASSED

Started: 2018-02-23 02:24:05
Finished: 2018-02-23 02:47:21

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-927943 branch from bf3bfd0 to b7d1a28 Feb 22, 2018

[css-typed-om] Add unsupported tests for color properties.
For color properties, we support 'currentcolor' as a CSSKeywordValue,
but any other value (including identifiers like 'red') are not supported
and are converted to base CSSStyleValues.

We add tests for most color related properties. We are failing the
text-emphasis-color one because we haven't unprefixed it yet.

We change the code to make this work.

Bug: 774887
Change-Id: Ide5463b9f67b63568ff32bd34e977faf16964bc1
Reviewed-on: https://chromium-review.googlesource.com/927943
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538668}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-927943 branch from b7d1a28 to fc3d2fb Feb 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5496784 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-927943 branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.