Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[css-typed-om] Ensure StylePropertyMapReadonly IDL matches spec."" #9621

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 22, 2018

This reverts commit 35bfb10373c5b34c193ad9a7c569d6aa429028fc.

Reason for revert: Trying to reland.

Original change's description:

Revert "[css-typed-om] Ensure StylePropertyMapReadonly IDL matches spec."

This reverts commit 43700726a48ebedf10af437c644ec46d862fb46b.

Reason for revert: Causes build failure on Google Chrome ChromeOS:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/45929

Original change's description:

[css-typed-om] Ensure StylePropertyMapReadonly IDL matches spec.

Spec added a new .size member, which we implement in this patch.

Bug: 812915
Change-Id: Ib48fc7b8053c41e4c79dc9cc280bc18376e5fbe0
Reviewed-on: https://chromium-review.googlesource.com/930101
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#538304}

TBR=nainar@chromium.org,shend@chromium.org

Change-Id: I442aebc331ddc97c09c870299ab0ab76f5ce7773
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 812915
Reviewed-on: https://chromium-review.googlesource.com/930179
Reviewed-by: Thomas Anderson thomasanderson@chromium.org
Commit-Queue: Thomas Anderson thomasanderson@chromium.org
Cr-Commit-Position: refs/heads/master@{#538309}

TBR=nainar@chromium.org

Bug: 812915
Change-Id: Ia45bc81d58a807448e00d21a33c97e2210712bb2
Reviewed-on: https://chromium-review.googlesource.com/930521
Reviewed-by: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#538321}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

Revert "Revert "[css-typed-om] Ensure StylePropertyMapReadonly IDL ma…
…tches spec.""

This reverts commit 35bfb10373c5b34c193ad9a7c569d6aa429028fc.

Reason for revert: Trying to reland.

Original change's description:
> Revert "[css-typed-om] Ensure StylePropertyMapReadonly IDL matches spec."
>
> This reverts commit 43700726a48ebedf10af437c644ec46d862fb46b.
>
> Reason for revert: Causes build failure on Google Chrome ChromeOS:
> https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/45929
>
> Original change's description:
> > [css-typed-om] Ensure StylePropertyMapReadonly IDL matches spec.
> >
> > Spec added a new .size member, which we implement in this patch.
> >
> > Bug: 812915
> > Change-Id: Ib48fc7b8053c41e4c79dc9cc280bc18376e5fbe0
> > Reviewed-on: https://chromium-review.googlesource.com/930101
> > Reviewed-by: nainar <nainar@chromium.org>
> > Commit-Queue: Darren Shen <shend@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#538304}
>
> TBR=nainar@chromium.org,shend@chromium.org
>
> Change-Id: I442aebc331ddc97c09c870299ab0ab76f5ce7773
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 812915
> Reviewed-on: https://chromium-review.googlesource.com/930179
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538309}

TBR=nainar@chromium.org

Bug: 812915
Change-Id: Ia45bc81d58a807448e00d21a33c97e2210712bb2
Reviewed-on: https://chromium-review.googlesource.com/930521
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538321}
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-22 03:20:46
Finished: 2018-02-22 03:33:26

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 4f06b0b into master Feb 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-930521 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.