Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Port another set of sticky tests to JS rather than reftests" #9625

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
4 participants
@foolip
Copy link
Contributor

foolip commented Feb 22, 2018

This reverts commit 913109149534a732bdb5461d0ba2759f5d2f50f4.

Reason for revert:
Multiple failures on Linux, for example:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/39500
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/9251

Original change's description:

Port another set of sticky tests to JS rather than reftests

Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
Reviewed-on: https://chromium-review.googlesource.com/882002
Reviewed-by: Robert Flack flackr@chromium.org
Commit-Queue: Stephen McGruer smcgruer@chromium.org
Cr-Commit-Position: refs/heads/master@{#532966}

TBR=flackr@chromium.org,smcgruer@chromium.org

Change-Id: I7a773131066157e0d4216d7fa7c228bd8bff2021
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/893536
Reviewed-by: Bret Sepulveda bsep@chromium.org
Commit-Queue: Bret Sepulveda bsep@chromium.org
Cr-Commit-Position: refs/heads/master@{#533000}

Revert "Port another set of sticky tests to JS rather than reftests"
This reverts commit 913109149534a732bdb5461d0ba2759f5d2f50f4.

Reason for revert:
Multiple failures on Linux, for example:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/39500
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/9251

Original change's description:
> Port another set of sticky tests to JS rather than reftests
>
> Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
> Reviewed-on: https://chromium-review.googlesource.com/882002
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532966}

TBR=flackr@chromium.org,smcgruer@chromium.org

Change-Id: I7a773131066157e0d4216d7fa7c228bd8bff2021
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/893536
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533000}
@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Feb 22, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 22, 2018

This is a manual export of the Chromium revert commit, using the instructions in bit.ly/ecosystem-infra-rotation. I've also verified that the result is identical to reverting commit c67d9e1 in wpt directly.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-22 06:17:54
Finished: 2018-02-22 06:30:35

View more information about this build on:

@foolip foolip merged commit bfe08e0 into master Feb 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the revert-chromium-export-9131091495 branch Feb 22, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 22, 2018

https://bugs.chromium.org/p/chromium/issues/detail?id=814617 explains what's going on here. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.