Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual tests for the copy, cut and paste events #9626

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@foolip
Copy link
Contributor

foolip commented Feb 22, 2018

Follows w3c/clipboard-apis#62.

Per manual testing, this fails in Chrome and Firefox because the event
is not compose, but passes in Safari. Edge not tested.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-23 10:29:31
Finished: 2018-02-23 10:39:40

View more information about this build on:

// assert_equals(event.target, document.body, "event.target");
assert_true(event.isTrusted, "event.isTrusted");
assert_true(event.composed, "event.composed");
});

This comment has been minimized.

Copy link
@TakayoshiKochi

TakayoshiKochi Feb 23, 2018

Member

Could you also add tests for "cut" and "paste" as well?

@wpt-pr-bot wpt-pr-bot requested review from garykac and hallvors Feb 23, 2018

@TakayoshiKochi

This comment has been minimized.

Copy link
Member

TakayoshiKochi commented Feb 23, 2018

BTW, I also investigated the supports status on each browser, and indeed Safari (WebKit) was the only
browser that sets "composed" flag to be true.

For Blink, the change is in progress:
https://chromium-review.googlesource.com/c/chromium/src/+/923671

I think Edge doesn't implement "composed" flag on Event object at all, as they haven't implemented Shadow DOM yet.

@foolip foolip force-pushed the copy-event-manual branch from 174e6ec to 103dd2c Feb 23, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 23, 2018

I've added tests for cut and paste as well, PTAL.

@TakayoshiKochi
Copy link
Member

TakayoshiKochi left a comment

Thanks, LGTM!

@foolip foolip merged commit ae0deb7 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the copy-event-manual branch Feb 23, 2018

@foolip foolip changed the title Add a manual test for the copy event Add manual tests for the copy, cut and paste events Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.