Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker: Update WPT test for resource timing #9627

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 22, 2018

Before this CL, the test assumed that there should be a
PerformanceResourceTiming for fetching 'resources/missing.jpg'.
As the spec says [1], this assumption is not guaranteed. In fact,
Chromium doesn't add PerformanceResourceTiming for resouces which
failed to load. This CL updates the test to check there is a
corresponding PerformanceResourceTiming entry before doing
verifications.

[1] https://w3c.github.io/resource-timing/#resources-included-in-the-performanceresourcetiming-interface

Bug: 782958
Change-Id: I85e75a8dade9f6620d22a54eaf97468f00360023
Reviewed-on: https://chromium-review.googlesource.com/930109
Reviewed-by: Matt Falkenhagen falken@chromium.org
Commit-Queue: Kenichi Ishibashi bashi@chromium.org
Cr-Commit-Position: refs/heads/master@{#538648}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-23 01:26:35
Finished: 2018-02-23 01:37:41

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-930109 branch from bc8bda4 to e6e6180 Feb 22, 2018

service worker: Update WPT test for resource timing
Before this CL, the test assumed that there should be a
PerformanceResourceTiming for fetching 'resources/missing.jpg'.
As the spec says [1], this assumption is not guaranteed. In fact,
Chromium doesn't add PerformanceResourceTiming for resouces which
failed to load. This CL updates the test to check there is a
corresponding PerformanceResourceTiming entry before doing
verifications.

[1] https://w3c.github.io/resource-timing/#resources-included-in-the-performanceresourcetiming-interface

Bug: 782958
Change-Id: I85e75a8dade9f6620d22a54eaf97468f00360023
Reviewed-on: https://chromium-review.googlesource.com/930109
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538648}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-930109 branch from e6e6180 to dabc9b6 Feb 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 30c0131 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-930109 branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.