Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make percentage height calculation quirk tests match implementations #9628
These tests are all failing in the same way in Chrome, Edge, Firefox and
They came up when looking at tests that have been failing for a very
I did this without looking at what the spec says. I think the first instance may just have been a mistake, since 200-10*2 = 180, but the ones involving namespaces I'm not sure about. https://quirks.spec.whatwg.org/#the-percentage-height-calculation-quirk does not take namespaces into account.
referenced this pull request
Feb 22, 2018
The ones involving namespaces now interact with the body element fills the viewport quirk, I think. An earlier revision of the spec aligned with gecko/presto but then gecko was changing or planning to change to webkit/blink behavior. The tests were not all updated.
So the behavior in impl is that the document element is not checked for being "html" in HTML namespace. The spec does check that for body fills html quirk. That's s for being consistent with how css 2.1 background applies to body.
But no objection to aligning with impl here.