Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make percentage height calculation quirk tests match implementations #9628

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
4 participants
@foolip
Copy link
Contributor

foolip commented Feb 22, 2018

These tests are all failing in the same way in Chrome, Edge, Firefox and
Safari: https://wpt.fyi/quirks/percentage-height-calculation.html

They came up when looking at tests that have been failing for a very
long time: https://docs.google.com/document/d/1kFYTqUMEbo9p87i6wAzORoicMWgHsuYwL2CgtvdhDaE/edit?usp=sharing

Make percentage height calculation quirk tests match implementations
These tests are all failing in the same way in Chrome, Edge, Firefox and
Safari: https://wpt.fyi/quirks/percentage-height-calculation.html

They came up when looking at tests that have been failing for a very
long time: https://docs.google.com/document/d/1kFYTqUMEbo9p87i6wAzORoicMWgHsuYwL2CgtvdhDaE/edit?usp=sharing

@wpt-pr-bot wpt-pr-bot added the quirks label Feb 22, 2018

@wpt-pr-bot wpt-pr-bot requested a review from zcorpan Feb 22, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 22, 2018

I did this without looking at what the spec says. I think the first instance may just have been a mistake, since 200-10*2 = 180, but the ones involving namespaces I'm not sure about. https://quirks.spec.whatwg.org/#the-percentage-height-calculation-quirk does not take namespaces into account.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-22 09:09:17
Finished: 2018-02-22 09:17:42

View more information about this build on:

@zcorpan

This comment has been minimized.

Copy link
Contributor

zcorpan commented Feb 22, 2018

The ones involving namespaces now interact with the body element fills the viewport quirk, I think. An earlier revision of the spec aligned with gecko/presto but then gecko was changing or planning to change to webkit/blink behavior. The tests were not all updated.

So the behavior in impl is that the document element is not checked for being "html" in HTML namespace. The spec does check that for body fills html quirk. That's s for being consistent with how css 2.1 background applies to body.

But no objection to aligning with impl here.

Filed whatwg/quirks#25

@zcorpan zcorpan merged commit f0b7c11 into master Jun 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zcorpan zcorpan deleted the percentage-height-calculation branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.