Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support VTTCue.positionAlign and lineAlign for WebVTT" #9629

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 22, 2018

This reverts commit 2c1d466d78db6df8b4c9fbe37ac5af1cb135bf34.

Reason for revert: https://crbug.com/814710

Conflicts with https://chromium-review.googlesource.com/836576 resolved.

Original change's description:

Support VTTCue.positionAlign and lineAlign for WebVTT

Implement VTTCue.[positionAlign and lineAlign] for WebVTT
Updated parsing logic
Exposed DOM API's
Updated Layout algorithm
Updated test expected results

Bug: 633690
Change-Id: I49970c068c53b462243ba8c7f314261b0e6455ce
Reviewed-on: https://chromium-review.googlesource.com/756142
Commit-Queue: srirama chandra sekhar srirama.m@samsung.com
Reviewed-by: srirama chandra sekhar srirama.m@samsung.com
Reviewed-by: Chris Harrelson chrishtr@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Fredrik Söderquist fs@opera.com
Cr-Commit-Position: refs/heads/master@{#525659}

TBR=fs@opera.com,chrishtr@chromium.org,srirama.m@samsung.com,foolip@chromium.org,k2.nagaraju@samsung.com

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 633690
Change-Id: Ib9f0b3dd1a4b679076ec55ec635337551f8b8806
Reviewed-on: https://chromium-review.googlesource.com/931481
Commit-Queue: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#538429}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-22 15:39:11
Finished: 2018-02-22 15:50:38

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-931481 branch from eb849b5 to 9bd9b8c Feb 22, 2018

Revert "Support VTTCue.positionAlign and lineAlign for WebVTT"
This reverts commit 2c1d466d78db6df8b4c9fbe37ac5af1cb135bf34.

Reason for revert: https://crbug.com/814710

Conflicts with https://chromium-review.googlesource.com/836576 resolved.

Original change's description:
> Support VTTCue.positionAlign and lineAlign for WebVTT
>
> Implement VTTCue.[positionAlign and lineAlign] for WebVTT
> Updated parsing logic
> Exposed DOM API's
> Updated Layout algorithm
> Updated test expected results
>
> Bug: 633690
> Change-Id: I49970c068c53b462243ba8c7f314261b0e6455ce
> Reviewed-on: https://chromium-review.googlesource.com/756142
> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
> Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#525659}

TBR=fs@opera.com,chrishtr@chromium.org,srirama.m@samsung.com,foolip@chromium.org,k2.nagaraju@samsung.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 633690
Change-Id: Ib9f0b3dd1a4b679076ec55ec635337551f8b8806
Reviewed-on: https://chromium-review.googlesource.com/931481
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538429}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-931481 branch from 9bd9b8c to 9639370 Feb 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e4b890b into master Feb 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-931481 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.