Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3 ref layout tests for Skia DAA rebaseline #9630

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 22, 2018

Once this is in, our rebaseline CL should only include PNG files.

Bug: skia:7641
Change-Id: I3ab85dfcafd317a575b2f77f5da9c5e57dfd3c70
Reviewed-on: https://chromium-review.googlesource.com/930423
WPT-Export-Revision: 23ab60421d2b1db99f96734b0b1404e9faf750d3

Prepare 3 ref layout tests for Skia DAA rebaseline
Once this is in, our rebaseline CL should only include PNG files.

Bug: skia:7641
Change-Id: I3ab85dfcafd317a575b2f77f5da9c5e57dfd3c70
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-22 14:04:32
Finished: 2018-02-22 14:10:35

View more information about this build on:

@frivoal frivoal added the wg-css label Apr 30, 2018

@csnardi

This comment has been minimized.

Copy link
Member

csnardi commented May 31, 2018

See the CL for context, https://chromium-review.googlesource.com/c/chromium/src/+/923767 was the final change landed which created an expectation that this test could either pass or fail depending on the path taken. The test should probably be modified then, but closing this PR as the CL that landed superseding this CL did not have this change.

@csnardi csnardi closed this May 31, 2018

@csnardi csnardi deleted the chromium-export-cl-930423 branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.