Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Rejig CSSResourceValue hierarchy. #9641

Merged
merged 1 commit into from Feb 25, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 23, 2018

We implement the new CSSImageValue, which is an opaque object with no
constructor. We also had to change the testsuite.js a bit to test it.

Bug: 545318
Change-Id: I0ae719c5380e01ff9423e0ff0684afe547de1bb0
Reviewed-on: https://chromium-review.googlesource.com/934001
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#538730}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 23, 2018

Build ERRORED

Started: 2018-02-24 04:35:13
Finished: 2018-02-24 05:18:27

Failing Jobs

  • firefox:nightly
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 24, 2018

Weird, I can't seem to restart the build. I'll rebase the commit as a workaround.

[css-typed-om] Rejig CSSResourceValue hierarchy.
We implement the new CSSImageValue, which is an opaque object with no
constructor. We also had to change the testsuite.js a bit to test it.

Bug: 545318
Change-Id: I0ae719c5380e01ff9423e0ff0684afe547de1bb0
Reviewed-on: https://chromium-review.googlesource.com/934001
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538730}
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 25, 2018

I still can't make sense of this failure. I suspect a timeout due to the number of affected tests, but am not sure. Will try a PR with a subset of these changes to see if Travis still fails in the same way.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Feb 25, 2018

Hmm, actually, the set of affected tests is pretty large, 94, probably because testhelper.js was modified. A lot of the tests pass on Chrome Dev, so I believe the explanation here is that because the browser is restarted between failing tests, it takes much longer in other browsers, and all have taken 40+ minutes and failed. Trying to run wpt run firefox css/css-typed-om once locally is certainly not fast.

I'm going to blame #7660 for this as well, force merge, and accept the consequences if I'm wrong and this really breaks something.

@foolip foolip merged commit 5ca972e into master Feb 25, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-934001 branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.