Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test SpeechSynthesisUtterance volume attribute #9642

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@guest271314
Copy link

guest271314 commented Feb 23, 2018

TODO: automate test to verify audio output of speechSynthesis.speak() using Web Audio API.

guest271314 added some commits Feb 23, 2018

Create SpeechSynthesisUtterance-volume-attribute-test-manual.html
Test SpeechSynthesisUtterance volume attribute. TODO: automate test to verify audio output of speechSynthesis.speak() using Web Audio API.
Merge pull request #1 from guest271314/guest271314-speech-api-tests
Create SpeechSynthesisUtterance-volume-attribute-test-manual.html
@guest271314

This comment has been minimized.

Copy link
Author

guest271314 commented Feb 24, 2018

@foolip Can you review this pull request? How to delete b5a666a from the PR? The commit necessary is 2391cff

@guest271314

This comment has been minimized.

Copy link
Author

guest271314 commented Mar 4, 2018

@annevk What is necessary for this test PR to be incorporated into the Web Platform Tests?

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Mar 7, 2018

You'll need to fix the CI failure.

And it seems you'll need review from one of the OWNERS: @andrenatal @fleizach @gshires @jdsmith3000. Not sure why they were not pinged.

@guest271314

This comment has been minimized.

Copy link
Author

guest271314 commented Mar 7, 2018

@annevk Not certain how to adjust the existing PR to remove the commit b5a666a (which was the first PR attempt) using github interface. Should the PR be deleted then resubmitted without that commit that failed continuous intergration?

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Mar 7, 2018

You could rebase and force push.

@guest271314

This comment has been minimized.

Copy link
Author

guest271314 commented Mar 8, 2018

@annevk Unfortunately was not able to clone this repository (200MB+) at the command line, due to device capacity. Instead forked the repository, created this PR and compared changed to the fork. Is it possible to rebase and force push using GitHub interface?

Should an issue be filed concerning the ever-increasing size of this repository?

Is there some means to clone and push only specific folders; for example https://github.com/w3c/web-platform-tests/tree/master/speech-api, and create a PR at the command line for only that repository?

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Mar 8, 2018

I don't really know the answers to those questions.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 8, 2018

Try git clone --depth 10 to see if that might cut down enough on the size.

@guest271314

This comment has been minimized.

Copy link
Author

guest271314 commented Mar 8, 2018

@foolip What does that option do?

@guest271314

This comment has been minimized.

Copy link
Author

guest271314 commented Mar 8, 2018

@foolip Did not make it to speech-api folder

$ git clone --depth 10 https://github.com/w3c/web-platform-tests.git
Cloning into 'web-platform-tests'...
remote: Counting objects: 57700, done.
remote: Compressing objects: 100% (29262/29262), done.
remote: Total 57700 (delta 32113), reused 41654 (delta 27113), pack-reused 0
Receiving objects: 100% (57700/57700), 48.34 MiB | 686.00 KiB/s, done.
Resolving deltas: 100% (32113/32113), done.
Checking connectivity... done.
fatal: cannot create directory at 'html/infrastructure/fetching-resources/processing-model': No space left on device
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.