Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USVString] Add a rough test case for navigator.registerProtocolHandler #9643

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 23, 2018

Although r525634 updated the URL type of registerProtocolHandler from DOMString
to USVString, it didn't add a test case because it was a bit complex. Though
it's still hard to add a test case for it, this CL adds a rough test case for now.

Bug: 790860
Change-Id: Ia688494293274ab2c0aa62f9e33a588ca80d2a82
Reviewed-on: https://chromium-review.googlesource.com/933668
Reviewed-by: Kentaro Hara haraken@chromium.org
Reviewed-by: Kenichi Ishibashi bashi@chromium.org
Commit-Queue: Gyuyoung Kim gyuyoung.kim@lge.com
Cr-Commit-Position: refs/heads/master@{#539114}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 23, 2018

Build PASSED

Started: 2018-02-26 13:18:45
Finished: 2018-02-26 13:25:32

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-933668 branch from 796660e to 0b3f9f2 Feb 26, 2018

[USVString] Add a rough test case for navigator.registerProtocolHandler
Although r525634 updated the URL type of registerProtocolHandler from DOMString
to USVString, it didn't add a test case because it was a bit complex. Though
it's still hard to add a test case for it, this CL adds a rough test case for now.

Bug: 790860
Change-Id: Ia688494293274ab2c0aa62f9e33a588ca80d2a82
Reviewed-on: https://chromium-review.googlesource.com/933668
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#539114}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-933668 branch from 0b3f9f2 to c706f8c Feb 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit afe0178 into master Feb 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-933668 branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.