Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] The padding box needs to exclude both borders and scrollbars. #9646

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 23, 2018

We forgot to subtract space taken up by scrollbars. Now that we do, we
also need NGBlockNode::GetScrollbarSizes() to add the horizontal
scrollbar on the correct side. Need to check with the layout object, not
directly with computed style. This matters e.g. if the object in
question is the LayoutView, which always places it on the right hand
side, even if document direction is RTL.

Also fix static block offset in flipped blocks writing mode. We got it
wrong, because we flipped an offset relative to the border edge around
the padding box. That's a regression from
https://chromium-review.googlesource.com/926004

Since I managed to break stuff without any tests regressing, I added a
few to wpt/css/css-flexbox/ (it doesn't really matter which layout model
to test with, as long as the containing block is in legacy layout, so
I just picked flexbox).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9527e8bb013b792a6b8ef58b370efe02b071c8bf
Reviewed-on: https://chromium-review.googlesource.com/931502
Reviewed-by: Aleks Totic atotic@chromium.org
Reviewed-by: Christian Biesinger cbiesinger@chromium.org
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#538871}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 23, 2018

Build PASSED

Started: 2018-02-23 20:13:36
Finished: 2018-02-23 20:22:45

Failing Jobs

  • safari:11.0

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-931502 branch from ef464dc to 6b0e30f Feb 23, 2018

[LayoutNG] The padding box needs to exclude both borders and scrollbars.
We forgot to subtract space taken up by scrollbars. Now that we do, we
also need NGBlockNode::GetScrollbarSizes() to add the horizontal
scrollbar on the correct side. Need to check with the layout object, not
directly with computed style. This matters e.g. if the object in
question is the LayoutView, which always places it on the right hand
side, even if document direction is RTL.

Also fix static block offset in flipped blocks writing mode. We got it
wrong, because we flipped an offset relative to the border edge around
the padding box. That's a regression from
https://chromium-review.googlesource.com/926004

Since I managed to break stuff without any tests regressing, I added a
few to wpt/css/css-flexbox/ (it doesn't really matter which layout model
to test with, as long as the containing block is in legacy layout, so
I just picked flexbox).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9527e8bb013b792a6b8ef58b370efe02b071c8bf
Reviewed-on: https://chromium-review.googlesource.com/931502
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538871}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-931502 branch from 6b0e30f to f8540e5 Feb 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0fe9f01 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-931502 branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.