Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code prepare_environment in browser.py #9653

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@foolip
Copy link
Contributor

foolip commented Feb 23, 2018

This isn't called from anywhere. The DBUS_SESSION_BUS_ADDRESS bits were
added in #5893 but was
unused even then. Since then it's been copied around a lot.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Feb 23, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Feb 23, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 23, 2018

Don't merge this even if reviewed. Needs to be rebased after #9649 is landed and update the documentation.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 23, 2018

Build PASSED

Started: 2018-02-25 04:43:22
Finished: 2018-02-25 04:57:01

View more information about this build on:

Remove dead code prepare_environment in browser.py
This isn't called from anywhere. The DBUS_SESSION_BUS_ADDRESS bits were
added in #5893 but was
unused even then. Since then it's been copied around a lot.

@foolip foolip force-pushed the dead-code-prepare_environment branch from e4b3335 to 8e296d0 Feb 25, 2018

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 25, 2018

Rebased and figured the documentation doesn't need to change. Ready for review.

@gsnedders gsnedders merged commit c58e51b into master Feb 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the dead-code-prepare_environment branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.