Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more chrome webaudio layout tests to WPT #9654

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 23, 2018

Move the DelayNode, DynamicsCompressorNode, and GainNode tests to
WPT.

Manually verified that Firefox passes these texts, except for the
no-dezipper tests which use suspend() on an offline context.

The tests that weren't moved are Chrome-specific.

Bug: 745778
Change-Id: Iea2d31fd556d51ddcd63e9d139e53f05732261fe
Reviewed-on: https://chromium-review.googlesource.com/922544
Reviewed-by: Hongchan Choi hongchan@chromium.org
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/heads/master@{#539200}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 23, 2018

Build PASSED

Started: 2018-02-26 18:59:17
Finished: 2018-02-26 19:06:20

Failing Jobs

  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/webaudio/the-audio-api/the-delaynode-interface/delaynode.html   TIMEOUT: 7
OK: 3
  delay.delayTime.defaultValue is equal to 0. PASS: 3
  delay.delayTime.value = 0.5 is equal to 0.5. PASS: 3
  delay.delayTime.value is equal to 0. PASS: 3
  Delaying test signal by 0.5 sec was done correctly PASS: 3
  delay.numberOfInputs is equal to 1. PASS: 3
  delay.numberOfOutputs is equal to 1. PASS: 3
  < [test] All assertions passed. (total 6 assertions) PASS: 3
  > [test] Tests attribute and basic functionality of DelayNode PASS: 3
/webaudio/the-audio-api/the-delaynode-interface/delaynode-maxdelay.html   TIMEOUT: 8
OK: 2
  Delaying test signal by 1.5 sec was done correctly PASS: 2
  > [test] Basic functionality of DelayNode with a non-default max delay time PASS: 2
/webaudio/the-audio-api/the-delaynode-interface/delaynode-maxdelaylimit.html   TIMEOUT: 2
OK: 8
  () => context.createDelay(0) threw NotSupportedError: "NotSupportedError". PASS: 8
  () => context.createDelay(180) threw NotSupportedError: "NotSupportedError". PASS: 8
  () => context.createDelay(-1) threw NotSupportedError: "NotSupportedError". PASS: 8
  () => context.createDelay(NaN) threw TypeMismatchError: "TypeMismatchError". PASS: 8
  > [test] Tests attribute and maximum allowed delay of DelayNode PASS: 8
/webaudio/the-audio-api/the-delaynode-interface/delaynode-scheduling.html   TIMEOUT: 1
OK: 9
  > [test] DelayNode delayTime parameter can be scheduled at a given time PASS: 9
/webaudio/the-audio-api/the-delaynode-interface/no-dezippering.html   TIMEOUT: 3
ERROR: 7
  > [test0] Test DelayNode has no dezippering PASS: 7
Move more chrome webaudio layout tests to WPT
Move the DelayNode, DynamicsCompressorNode, and GainNode tests to
WPT.

Manually verified that Firefox passes these texts, except for the
no-dezipper tests which use suspend() on an offline context.

The tests that weren't moved are Chrome-specific.

Bug: 745778
Change-Id: Iea2d31fd556d51ddcd63e9d139e53f05732261fe
Reviewed-on: https://chromium-review.googlesource.com/922544
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539200}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-922544 branch from 9f2e4c6 to ba195bd Feb 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1dd2953 into master Feb 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-922544 branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.