Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on element before sending special keys in WebDriver tests #9655

Merged
merged 2 commits into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@jimevans
Copy link
Contributor

jimevans commented Feb 24, 2018

This commit is, admittedly, to work around a browser-specific (or perhaps
an operating-system-specific) issue. When the Alt key is pressed on
Windows, the system menu bar is activated. This causes the page in at
least one browser to lose focus, and the key reporting element will no
longer receive keydown and keyup events until focus is restored. This
causes failures in succeeding tests.

Clicking on element before sending special keys in WebDriver tests
This commit is, admittedly, to work around a browser-specific (or perhaps
an operating-system-specific) issue. When the Alt key is pressed on
Windows, the system menu bar is activated. This causes the page in at
least one browser to lose focus, and the key reporting element will no
longer receive keydown and keyup events until focus is restored. This
causes failures in succeeding tests.
@jimevans

This comment has been minimized.

Copy link
Contributor Author

jimevans commented Feb 24, 2018

If it's unwise or unacceptable to implement such a platform-specific workaround, that's perfectly fine. I'm willing to withdraw the PR and live with documenting the failures if that's the case.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 24, 2018

Build PASSED

Started: 2018-03-05 19:32:51
Finished: 2018-03-05 19:49:41

Failing Jobs

  • chrome:dev

View more information about this build on:

@andreastt

This comment has been minimized.

Copy link
Member

andreastt commented Feb 25, 2018

Can we make this conditional on IE? I believe we store the capabilities in session.capabilities.

@jimevans

This comment has been minimized.

Copy link
Contributor Author

jimevans commented Feb 25, 2018

Of course. It might make more sense to make it conditional on Windows, though, if other implementations have the same issue on that platform.

@andreastt

This comment has been minimized.

Copy link
Member

andreastt commented Feb 25, 2018

It doesn’t appear to be a problem in Firefox on Windows.

@andreastt andreastt merged commit b7c37bd into web-platform-tests:master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jimevans jimevans deleted the jimevans:alt-key branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.