Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add more property tests. #9659

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 25, 2018

Add more property tests. Most test failures are because our Blink
implementation for these properties are lagging behind spec. The only
weird one is line-height, which seems to return 'normal' for negative
values even though the spec doesn't say that anywhere.

Bug: 774887
Change-Id: I9d4a6918b5e9b5772230999b18c6eec4934bcf19
Reviewed-on: https://chromium-review.googlesource.com/936821
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#539222}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 25, 2018

Build PASSED

Started: 2018-02-26 20:30:07
Finished: 2018-02-26 20:40:59

View more information about this build on:

[css-typed-om] Add more property tests.
Add more property tests. Most test failures are because our Blink
implementation for these properties are lagging behind spec. The only
weird one is line-height, which seems to return 'normal' for negative
values even though the spec doesn't say that anywhere.

Bug: 774887
Change-Id: I9d4a6918b5e9b5772230999b18c6eec4934bcf19
Reviewed-on: https://chromium-review.googlesource.com/936821
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539222}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-936821 branch from bc4c393 to 245e5a5 Feb 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9659a35 into master Feb 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-936821 branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.