Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add property tests for text-decoration-line. #9660

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 26, 2018

text-decoration-line uses a weird internal structure for CSSValues,
so we have to encode/decode to that structure when getting/setting.
Failing tests because for some reason we ignore 'blink' for the
computed value. Blink also doesn't support 'spelling-error' and
'grammar-error' yet.

Bug: 774887
Change-Id: Ie2a1b7abf3a2d3a8134e5686a1c6da8d42c21ac3
Reviewed-on: https://chromium-review.googlesource.com/936723
WPT-Export-Revision: f4b370069026f2d4c69c0f8890679da43e1985ca

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 26, 2018

Build PASSED

Started: 2018-03-15 05:59:44
Finished: 2018-03-15 06:04:51

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-936723 branch from d365f15 to 2c50590 Mar 15, 2018

[css-typed-om] Add property tests for text-decoration-line.
text-decoration-line uses a weird internal structure for CSSValues,
so we have to encode/decode to that structure when getting/setting.
Failing tests because for some reason we ignore 'blink' for the
computed value. Blink also doesn't support 'spelling-error' and
'grammar-error' yet.

Bug: 774887
Change-Id: Ie2a1b7abf3a2d3a8134e5686a1c6da8d42c21ac3

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-936723 branch from 2c50590 to ec296fb Mar 15, 2018

@frivoal frivoal added the wg-css label Apr 30, 2018

@csnardi

This comment has been minimized.

Copy link
Member

csnardi commented May 31, 2018

Most of this was landed with #10189. Only lines 26-28 were not included, but I'm assuming that was an intentional choice and not by accident.

@csnardi csnardi closed this May 31, 2018

@csnardi csnardi deleted the chromium-export-cl-936723 branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.