Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for GeolocationSensor.read() #9662

Merged
merged 2 commits into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@Honry
Copy link
Contributor

Honry commented Feb 26, 2018

covers:

  • verify sensor reading when call read() method
  • verify sensor reading when signal is set to null
  • throw AbortError when singal's abort flag is set
  • throw SecurityError when disabled by Feature Policy
  • AbortError takes priority when disabled by Feature Policy

@wpt-pr-bot wpt-pr-bot requested a review from anssiko Feb 26, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 26, 2018

Build PASSED

Started: 2018-02-26 05:02:09
Finished: 2018-02-26 05:09:25

View more information about this build on:

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Feb 26, 2018

@anssiko, @pozdnyakov, @alexshalamov, PTAL. And please let me know if there's coverage gap. Thanks!

@Honry Honry requested review from pozdnyakov and alexshalamov Feb 26, 2018

Honry added some commits Feb 25, 2018

Add tests for GeolocationSensor.read()
covers:
  - verify sensor reading when call read() method
  - verify sensor reading when signal is set to null
  - throw AbortError when singal's abort flag is set
  - throw SecurityError when disabled by Feature Policy
  - AbortError takes priority when disabled by Feature Policy
@anssiko

This comment has been minimized.

Copy link
Member

anssiko commented Feb 27, 2018

PTAL @kenchris

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Mar 7, 2018

@kenchris, friendly ping. :)

@anssiko

This comment has been minimized.

Copy link
Member

anssiko commented Mar 13, 2018

@Honry I think this can be landed.

@Honry Honry merged commit 772ed22 into web-platform-tests:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Honry Honry deleted the Honry:geo-read branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.