Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 2: show(details) resolves tests #9663

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
5 participants
@marcoscaceres
Copy link
Contributor

marcoscaceres commented Feb 26, 2018

Part 1 is #9617

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 26, 2018

Build PASSED

Started: 2018-02-26 09:30:42
Finished: 2018-02-26 09:38:57

View more information about this build on:

@marcoscaceres marcoscaceres force-pushed the show_promise_part_2 branch from 8b7d137 to bb58c18 Feb 26, 2018

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Feb 27, 2018

@rsolomakhin, wow! thanks for the super speedy review.

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Feb 27, 2018

@sideshowbarker, could you please grant @rsolomakhin write access? Above, GitHub is complaining that his review doesn't count because he is missing write access.

@sideshowbarker

This comment has been minimized.

Copy link
Member

sideshowbarker commented Feb 27, 2018

@sideshowbarker, could you please grant @rsolomakhin write access?

yup, done

@marcoscaceres marcoscaceres merged commit c4970cb into master Feb 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoscaceres marcoscaceres deleted the show_promise_part_2 branch Feb 27, 2018

kereliuk added a commit to kereliuk/web-platform-tests that referenced this pull request Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.