Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Need to lay out legacy objects to figure out their inline size. #9673

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 26, 2018

NG cannot always calculate the correct size of objects that are laid out
by the legacy engine, so just lay them out if we need to know their
size.

The computed CSS width on a table may not end up as its used value, for
instance.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaa327ad21055d6c1af96241b5403193c8b4b5ba3
Reviewed-on: https://chromium-review.googlesource.com/937261
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#539201}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 26, 2018

Build PASSED

Started: 2018-02-26 18:49:18
Finished: 2018-02-26 18:55:59

View more information about this build on:

[LayoutNG] Need to lay out legacy objects to figure out their inline …
…size.

NG cannot always calculate the correct size of objects that are laid out
by the legacy engine, so just lay them out if we need to know their
size.

The computed CSS width on a table may not end up as its used value, for
instance.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaa327ad21055d6c1af96241b5403193c8b4b5ba3
Reviewed-on: https://chromium-review.googlesource.com/937261
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539201}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-937261 branch from 3c7f5a1 to f5fd3f1 Feb 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c3e1a51 into master Feb 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-937261 branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.