Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollTo and scrollBy should land on snap points. #9678

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 26, 2018

According to spec,
https://drafts.csswg.org/css-scroll-snap-1/#scroll-types,
programmatically scrolling such as scrollTo and scrollBy should land on
snap points.

Bug: 803606
Change-Id: I1e70d88f31a2b2f93c92cc063adf653ed923adeb
Reviewed-on: https://chromium-review.googlesource.com/889936
Reviewed-by: David Bokan bokan@chromium.org
Commit-Queue: Sandra Sun sunyunjia@chromium.org
Cr-Commit-Position: refs/heads/master@{#540166}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 26, 2018

Build PASSED

Started: 2018-03-01 16:02:43
Finished: 2018-03-01 16:09:42

Failing Jobs

  • chrome:dev
  • safari:11.0

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-889936 branch 3 times, most recently from b251c6f to b6aa0fb Feb 28, 2018

scrollTo and scrollBy should land on snap points.
According to spec,
https://drafts.csswg.org/css-scroll-snap-1/#scroll-types,
programmatically scrolling such as scrollTo and scrollBy should land on
snap points.

Bug: 803606
Change-Id: I1e70d88f31a2b2f93c92cc063adf653ed923adeb
Reviewed-on: https://chromium-review.googlesource.com/889936
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540166}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-889936 branch from b6aa0fb to 876c80a Mar 1, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0f3fa6c into master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-889936 branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.