Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-layout-api] Populate children, and pass into layout() function #9680

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 26, 2018

This introduces the LayoutChild API surface, (which only has a styleMap
accessor currently).

Each LayoutBox which is a child of a LayoutCustom will hold onto a
LayoutChild object, acting as the script interface for the web
developer.

Bug: 726125
Change-Id: Iecdb01a38c0712dcda063b485c4207bde59f3995
Reviewed-on: https://chromium-review.googlesource.com/933092
Commit-Queue: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Reviewed-by: Koji Ishii kojii@chromium.org
Cr-Commit-Position: refs/heads/master@{#539928}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 27, 2018

Build ERRORED

Started: 2018-03-01 04:53:12
Finished: 2018-03-01 05:28:05

Failing Jobs

  • firefox:nightly
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-933092 branch 4 times, most recently from 69ad8cc to 7ccdd1e Feb 27, 2018

[css-layout-api] Populate children, and pass into layout() function
This introduces the LayoutChild API surface, (which only has a styleMap
accessor currently).

Each LayoutBox which is a child of a LayoutCustom will hold onto a
LayoutChild object, acting as the script interface for the web
developer.

Bug: 726125
Change-Id: Iecdb01a38c0712dcda063b485c4207bde59f3995
Reviewed-on: https://chromium-review.googlesource.com/933092
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539928}

@foolip foolip force-pushed the chromium-export-cl-933092 branch from 7ccdd1e to a0b559f Mar 1, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 1, 2018

Firefox job was failing and Travis didn't even have the log, so I rebased this on master to give it another go. (Restart seems to not work.)

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 1, 2018

This time there was a log:
https://api.travis-ci.org/v3/job/347597990/log.txt

There were 72 affected tests, and by searching for some of the names of the first and last affect tests, it seems like we were in the middle of the 5th run when it broke:

Log reached capacity (3145728 bytes); output disabled.


No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

If "output disabled" means what it seems, then I think that #9657 is the culprit here. Will comment there and force merge this.

@foolip foolip merged commit 41ab079 into master Mar 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-933092 branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.