Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Implement shorthands for .get/.getAll/.has. #9681

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 27, 2018

This patch implements shorthands for stylemap.get/getAll/has. Shorthands
are implemented as a base CSSStyleValue. They are different to other
properties because they cannot be converted to a single CSSValue.
Instead, we need to store the CSSValues of their longhands so that
they can be set again on the same property.

Patches to come:

  • styleMap.set/update
  • Serialization of these values.

Bug: 816722
Change-Id: Ia2c3f694809c219566b965ebfae40bc38d74f4c5
Reviewed-on: https://chromium-review.googlesource.com/938881
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#539594}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 27, 2018

Build PASSED

Started: 2018-02-28 01:09:49
Finished: 2018-02-28 01:31:10

Failing Jobs

  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/css/css-typed-om/the-stylepropertymap/inline/getAll-shorthand.html   TIMEOUT: 1
OK: 9
  StylePropertyMap.getAll() with a shorthand property set explicitly in inline style returns a base CSSStyleValue FAIL: 9
Unable to get property 'getAll' of undefined or null reference
  StylePropertyMap.getAll() with a shorthand property that is partially in inline style returns empty list FAIL: 9
Unable to get property 'getAll' of undefined or null reference
[css-typed-om] Implement shorthands for .get/.getAll/.has.
This patch implements shorthands for stylemap.get/getAll/has. Shorthands
are implemented as a base CSSStyleValue. They are different to other
properties because they cannot be converted to a single CSSValue.
Instead, we need to store the CSSValues of their longhands so that
they can be set again on the same property.

Patches to come:
- styleMap.set/update
- Serialization of these values.

Bug: 816722
Change-Id: Ia2c3f694809c219566b965ebfae40bc38d74f4c5
Reviewed-on: https://chromium-review.googlesource.com/938881
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539594}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-938881 branch from d9b40df to ffbb483 Feb 28, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1d8bc90 into master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-938881 branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.