Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCapabilities() should not have range properties without valid values #9688

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 27, 2018

This CL ensures that MediaStreamTrack.getCapabilities() does not have
range properties if they don't have a valid range.

Bug: 293292
Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d
Reviewed-on: https://chromium-review.googlesource.com/938983
Commit-Queue: Guido Urdaneta guidou@chromium.org
Reviewed-by: Guido Urdaneta guidou@chromium.org
Cr-Commit-Position: refs/heads/master@{#539778}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 27, 2018

Build PASSED

Started: 2018-02-28 10:52:10
Finished: 2018-02-28 11:00:38

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/mediacapture-streams/MediaStreamTrack-getCapabilities.https.html   TIMEOUT: 3
OK: 7
  MediaStreamTrack GetCapabilities FAIL: 7
promise_test: Unhandled rejection with value: object "Error: Invalid constraint"

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-938983 branch from 3fd071d to 07941be Feb 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title getCapabilities() should not have properties without valid values getCapabilities() should not have range properties without valid values Feb 28, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-938983 branch 3 times, most recently from 8f2d5a2 to 08b12ce Feb 28, 2018

getCapabilities() should not have range properties without valid values
This CL ensures that MediaStreamTrack.getCapabilities() does not have
range properties if they don't have a valid range.

Bug: 293292
Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d
Reviewed-on: https://chromium-review.googlesource.com/938983
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539778}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-938983 branch from 08b12ce to 120a7f3 Feb 28, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ca3bede into master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-938983 branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.