Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for data: URLs with space in body #9693

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
5 participants
@foolip
Copy link
Contributor

foolip commented Feb 27, 2018

This is to bring attention to the surprising difference between
application/xml, application/javascript and text/javascript. In Chrome
and Firefox, only the application/javascript case fails.

Add more tests for data: URLs with space in body
This is to bring attention to the surprising difference between
application/xml, application/javascript and text/javascript. In Chrome
and Firefox, only the application/javascript case fails.
@annevk

annevk approved these changes Feb 27, 2018

Copy link
Member

annevk left a comment

@domenic should probably r+ too.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 27, 2018

Build PASSED

Started: 2018-02-27 15:20:15
Finished: 2018-02-27 15:28:57

View more information about this build on:

@domenic
Copy link
Member

domenic left a comment

All tests pass with jsdom/data-urls, implying they most likely match the spec.

Maybe wroth adding a comment as to why we're testing these variations which should theoretically be redundant.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 27, 2018

Can't add comments in JSON, or did you have a trick in mind?

@domenic

This comment has been minimized.

Copy link
Member

domenic commented Feb 28, 2018

Hmm, usually in these data files we do a thing where a line that is just a string (instead of an object/array or whatever) is skipped by the processing code. But I guess I don't see that here. Oh well, might as well merge as-is.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 28, 2018

Do you have an example of that? I was thinking of using https://github.com/json5/json5, but dependencies that we have to keep updating are annoying.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Feb 28, 2018

I see, I can try to do the same here if you like.

@domenic

This comment has been minimized.

Copy link
Member

domenic commented Feb 28, 2018

Seems nice, but I don't insist on blocking the review :)

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Mar 8, 2018

Oh, and instead I just left this sitting. Retracting my promise, I'll just merge as is.

@foolip foolip merged commit 08d063d into master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the more-data-url-space-tests branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.