Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "webauthn: support the appid extension." #9698

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 28, 2018

This reverts commit 831be59aae45ff279e0eac88f736be2c2b033a2f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 539584 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgzMWJlNTlhYWU0NWZmMjc5ZTBlYWM4OGY3MzZiZTJjMmIwMzNhMmYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20Builder/51572

Sample Failed Step: compile

Original change's description:

webauthn: support the appid extension.

This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.

The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.

I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.

[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] w3c/webauthn#803

Bug: none
Change-Id: I22819adda99fbef9f10d38e797d08691dab7545d
Reviewed-on: https://chromium-review.googlesource.com/920659
Reviewed-by: Robert Sesek rsesek@chromium.org
Reviewed-by: Balazs Engedy engedy@chromium.org
Reviewed-by: Reilly Grant reillyg@chromium.org
Reviewed-by: Kim Paulhamus kpaulhamus@chromium.org
Cr-Commit-Position: refs/heads/master@{#539584}

Change-Id: Id3768dc2832c5987059b856407b191c8a9a14042
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none

Reviewed-on: https://chromium-review.googlesource.com/940581
WPT-Export-Revision: a494b3f7b77966be1536b34b1dc95b90ed287e1d

Revert "webauthn: support the appid extension."
This reverts commit 831be59aae45ff279e0eac88f736be2c2b033a2f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 539584 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgzMWJlNTlhYWU0NWZmMjc5ZTBlYWM4OGY3MzZiZTJjMmIwMzNhMmYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20Builder/51572

Sample Failed Step: compile

Original change's description:
> webauthn: support the appid extension.
>
> This extension allows credentials that were registered with U2F to be
> used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.
>
> The change does not include support for echoing the extension in the
> CollectedClientData[1], nor does it implement
> getClientExtensionResults[2]. It's fully usable without that logic and
> I have several questions about that part of the spec[3] that I would
> like to understand first.
>
> I did consider avoiding having a alternative app_param value in
> //device/u2f but a) the spec says that the given appid should be tried
> after the first one and b) this allows sites not to have to worry about
> which protocol they registered credentials with. Instead, they can just
> set this extension during the transition.
>
> [1] https://w3c.github.io/webauthn/#sec-client-data
> [2] https://w3c.github.io/webauthn/#iface-pkcredential
> [3] w3c/webauthn#803
>
> Bug: none
> Change-Id: I22819adda99fbef9f10d38e797d08691dab7545d
> Reviewed-on: https://chromium-review.googlesource.com/920659
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539584}

Change-Id: Id3768dc2832c5987059b856407b191c8a9a14042
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 28, 2018

Build PASSED

Started: 2018-02-28 00:27:39
Finished: 2018-02-28 00:43:24

View more information about this build on:

@Hexcles Hexcles closed this Apr 5, 2018

@Hexcles Hexcles deleted the chromium-export-cl-940581 branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.