Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug of <fieldset disabled> detection logic. #9709

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 28, 2018

HTMLFormControlElement::UpdateAncestorDisabledState() checked if the
highest is the first child of the highest disabled

. It should check child of every disabled fieldset ancestors.

Bug: 817181
Change-Id: I8f7dedd8089757d9eae726de359b0efe47cf9f44
Reviewed-on: https://chromium-review.googlesource.com/940644
Reviewed-by: Yoshifumi Inoue yosin@chromium.org
Commit-Queue: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#539776}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 28, 2018

Build PASSED

Started: 2018-02-28 10:22:28
Finished: 2018-02-28 10:30:37

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Fix a bug of <fieldset disabled> detection logic.
HTMLFormControlElement::UpdateAncestorDisabledState() checked if the
highest <legend> is the first <legend> child of the highest disabled
<fieldset>. It should check <lengend> child of every disabled fieldset
ancestors.

Bug: 817181
Change-Id: I8f7dedd8089757d9eae726de359b0efe47cf9f44
Reviewed-on: https://chromium-review.googlesource.com/940644
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539776}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-940644 branch from 643d201 to 0c070b6 Feb 28, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5107187 into master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-940644 branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.