Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] Modify reference tests so they fit in the viewport #9716

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
5 participants
@mrego
Copy link
Member

mrego commented Feb 28, 2018

Many reftests in this suite are bigger than the default viewport size
that browsers use when run the tests.
That means that only the first cases are checked, everything that is not
in the visible area won't be compared, so differences there won't be detected.

This patch modifies a bunch of tests to make them fit in the viewport.
Some of the tests are splitted in several files, as they have a lot of content.

Tests under folder text-transform/ still have this kind of issues,
some are actually way bigger, so that would need to be fixed
in a follow-up patch.

[css-text] Modify reference tests so they fit in the viewport
Many reftests in this suite are bigger than the default viewport size
that browsers use when run the tests.
That means that only the first cases are checked, everything that is not
in the visible area won't be compared, so differences there won't be detected.

This patch modifies a bunch of tests to make them fit in the viewport.
Some of the tests are splitted in several files, as they have a lot of content.

Tests under folder text-transform/ still have this kind of issues,
some are actually way bigger, so that would need to be fixed
in a follow-up patch.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 28, 2018

Build PASSED

Started: 2018-02-28 16:38:37
Finished: 2018-02-28 16:40:26

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 28, 2018

This is part of #5403.

@kojiishi
Copy link
Contributor

kojiishi left a comment

lgtm, thank you for working on this.

@mrego mrego merged commit 0d843d4 into web-platform-tests:master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrego mrego deleted the mrego:css-text-viewport branch Mar 1, 2018

@mrego mrego referenced this pull request Mar 6, 2018

Open

Tests relying on larger viewports #5403

1 of 604 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.