Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change navigation preload initiatorType to "navigation" #9717

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 28, 2018

As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the initiatorType
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss yoav@yoav.ws
Reviewed-by: Tsuyoshi Horo horo@chromium.org
Reviewed-by: Marijn Kruisselbrink mek@chromium.org
Cr-Commit-Position: refs/heads/master@{#540483}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 28, 2018

Build PASSED

Started: 2018-03-02 10:18:52
Finished: 2018-03-02 10:26:49

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-941342 branch 2 times, most recently from 2fa5ae3 to b59e326 Feb 28, 2018

Change navigation preload initiatorType to "navigation"
As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540483}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-941342 branch from b59e326 to d2dd9ad Mar 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 34c346b into master Mar 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-941342 branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.