Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :focus-visible pseudo class. #9722

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 1, 2018

Spec: https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-wN72ESFsyo

Adds :focus-visible to the list of known CSS pseudo classes. This change also adds a flag,
WasFocusedByMouse(), to UserActionElementSet which is exposed as Node.WasFocusedByMouse().
SelectorChecker will use this flag to check if a node matching :focus should also match
:focus-visible. By default, any node focused by mouse will NOT match :focus-visible. Any
node focused by keyboard will match :focus-visible.

Bug: 817199
R=aboxhall@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1a0aadc8ea653afc964865a277b2d4d2ccabe540
Reviewed-on: https://chromium-review.googlesource.com/897002
Commit-Queue: Rob Dodson robdodson@chromium.org
Reviewed-by: Kent Tamura tkent@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#540537}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 1, 2018

Build PASSED

Started: 2018-03-02 17:34:46
Finished: 2018-03-02 17:42:47

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897002 branch 3 times, most recently from f5294b7 to ccc15bd Mar 1, 2018

Implement :focus-visible pseudo class.
Spec: https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-wN72ESFsyo

Adds :focus-visible to the list of known CSS pseudo classes. This change also adds a flag,
WasFocusedByMouse(), to UserActionElementSet which is exposed as Node.WasFocusedByMouse().
SelectorChecker will use this flag to check if a node matching :focus should also match
:focus-visible. By default, any node focused by mouse will NOT match :focus-visible. Any
node focused by keyboard will match :focus-visible.

Bug: 817199
R=aboxhall@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1a0aadc8ea653afc964865a277b2d4d2ccabe540
Reviewed-on: https://chromium-review.googlesource.com/897002
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540537}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897002 branch from ccc15bd to 58d29c9 Mar 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8444227 into master Mar 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-897002 branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.