Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test serve start config #9726

Merged

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 1, 2018

Mostly throwing this up because I think this is a terrible test but I don't know how to do better? And it shows a real issue.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 1, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Mar 1, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 1, 2018

Build PASSED

Started: 2018-03-05 18:43:59
Finished: 2018-03-05 19:01:47

View more information about this build on:

@jgraham
Copy link
Contributor

jgraham left a comment

I don't love this either, but I guess it's OK.

import pytest

sys.path.insert(0, join(dirname(__file__), "..", ".."))
sys.path.insert(0, join(dirname(__file__), "..", "..", "..", "..")) # /

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 2, 2018

Contributor

Why do you need both of these on the path?

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 2, 2018

Author Contributor

Um, because I didn't change everything to use from tools, seemingly. Fixed.

@gsnedders gsnedders force-pushed the gsnedders:test_serve_start_config branch from 1a59f31 to 498c58f Mar 2, 2018

@gsnedders gsnedders force-pushed the gsnedders:test_serve_start_config branch 2 times, most recently from 855b6f0 to ca79597 Mar 2, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 2, 2018

Note that this covers both #9750 and #9651.

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 5, 2018

@jgraham if it's okay can we land it?

@@ -68,7 +68,7 @@ def env_extras(**kwargs):


def env_options():
return {"bind_hostname": "true"}
return {"bind_hostname": True}

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 5, 2018

Contributor

Let's just make True the default and remove all of these

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 5, 2018

Author Contributor

done

@gsnedders gsnedders force-pushed the gsnedders:test_serve_start_config branch from 9b93da0 to ccdd55f Mar 5, 2018

@gsnedders gsnedders force-pushed the gsnedders:test_serve_start_config branch from ccdd55f to 1911e75 Mar 5, 2018

@jgraham

jgraham approved these changes Mar 5, 2018

@gsnedders gsnedders merged commit 88f08cc into web-platform-tests:master Mar 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:test_serve_start_config branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.