Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Implement correct ordering for StylePropertyMaps. #9729

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 1, 2018

The correct ordering of properties depends on the type of style map:

  • Computed: css properties first, then vendor prefixed ones, then
    custom properties. Within each category, sort by code point.
  • Inline: same order as the CSSStyleDeclaration.
  • Declared: same order as the CSSRule.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly

Bug: 545318
Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625
Reviewed-on: https://chromium-review.googlesource.com/940381
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#540066}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 1, 2018

Build PASSED

Started: 2018-03-01 06:30:55
Finished: 2018-03-01 06:42:08

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

[css-typed-om] Implement correct ordering for StylePropertyMaps.
The correct ordering of properties depends on the type of style map:

- Computed: css properties first, then vendor prefixed ones, then
  custom properties. Within each category, sort by code point.
- Inline: same order as the CSSStyleDeclaration.
- Declared: same order as the CSSRule.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly

Bug: 545318
Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625
Reviewed-on: https://chromium-review.googlesource.com/940381
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540066}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-940381 branch from d77cd1d to ab00e9c Mar 1, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 66ffd92 into master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-940381 branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.