Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce InputDeviceInfo interface #9733

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 1, 2018

InputDeviceInfo extends MediaDeviceInfo and represents audio and video input
devices. These objects are the result of calling MediaDevices.enumerateDevices().
This interface gives access to the capabilities of the input device it represents
via getCapabilities() method which will be implemented in asubsequent CL.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78

Bug: 817769
Change-Id: Ic9a016a05e622ee02b86d567f64c3ed84f0926c3
Reviewed-on: https://chromium-review.googlesource.com/942961
Commit-Queue: Guido Urdaneta guidou@chromium.org
Reviewed-by: Guido Urdaneta guidou@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#541772}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 1, 2018

Build PASSED

Started: 2018-03-08 15:45:06
Finished: 2018-03-08 15:52:26

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/mediacapture-streams/MediaDevices-enumerateDevices.https.html   TIMEOUT: 1
OK: 9
  mediaDevices.enumerateDevices() is present and working on navigator PASS: 9
/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html   TIMEOUT: 2
OK: 8
  InputDeviceInfo interface: existence and properties of interface object FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  InputDeviceInfo interface: existence and properties of interface prototype object FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  InputDeviceInfo interface: existence and properties of interface prototype object's "constructor" property FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  InputDeviceInfo interface: existence and properties of interface prototype object's @@unscopables property FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  InputDeviceInfo interface object length FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  InputDeviceInfo interface object name FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  InputDeviceInfo interface: operation getCapabilities() FAIL: 8
assert_own_property: self does not have own property "InputDeviceInfo" expected property "InputDeviceInfo" missing
  MediaDeviceInfo interface: attribute deviceId PASS: 8
  MediaDeviceInfo interface: attribute groupId PASS: 8
  MediaDeviceInfo interface: attribute kind PASS: 8
  MediaDeviceInfo interface: attribute label PASS: 8
  MediaDeviceInfo interface: existence and properties of interface object PASS: 8
  MediaDeviceInfo interface: existence and properties of interface prototype object PASS: 8
  MediaDeviceInfo interface: existence and properties of interface prototype object's "constructor" property PASS: 8
  MediaDeviceInfo interface: existence and properties of interface prototype object's @@unscopables property PASS: 8
  MediaDeviceInfo interface object length PASS: 8
  MediaDeviceInfo interface object name PASS: 8
  MediaDeviceInfo interface: operation toJSON() PASS: 8
  MediaDevices interface: attribute ondevicechange FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: existence and properties of interface object FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: existence and properties of interface prototype object FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: existence and properties of interface prototype object's "constructor" property FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: existence and properties of interface prototype object's @@unscopables property FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface object length FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface object name FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: operation enumerateDevices() FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: operation getSupportedConstraints() FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaDevices interface: operation getUserMedia(MediaStreamConstraints) FAIL: 8
assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
  MediaStream interface: attribute active PASS: 8
  MediaStream interface: attribute id PASS: 8
  MediaStream interface: attribute onaddtrack PASS: 8
  MediaStream interface: attribute onremovetrack PASS: 8
  MediaStream interface: existence and properties of interface object PASS: 8
  MediaStream interface: existence and properties of interface prototype object PASS: 8
  MediaStream interface: existence and properties of interface prototype object's "constructor" property PASS: 8
  MediaStream interface: existence and properties of interface prototype object's @@unscopables property PASS: 8
  MediaStream interface object length PASS: 8
  MediaStream interface object name PASS: 8
  MediaStream interface: operation addTrack(MediaStreamTrack) PASS: 8
  MediaStream interface: operation clone() PASS: 8
  MediaStream interface: operation getAudioTracks() PASS: 8
  MediaStream interface: operation getTrackById(DOMString) PASS: 8
  MediaStream interface: operation getTracks() PASS: 8
  MediaStream interface: operation getVideoTracks() PASS: 8
  MediaStream interface: operation removeTrack(MediaStreamTrack) PASS: 8
  MediaStreamTrackEvent interface: attribute track PASS: 8
  MediaStreamTrackEvent interface: existence and properties of interface object FAIL: 10
PASS: 8
  MediaStreamTrackEvent interface: existence and properties of interface prototype object FAIL: 10
PASS: 8
  MediaStreamTrackEvent interface: existence and properties of interface prototype object's "constructor" property PASS: 8
  MediaStreamTrackEvent interface: existence and properties of interface prototype object's @@unscopables property PASS: 8
  MediaStreamTrackEvent interface object length PASS: 8
  MediaStreamTrackEvent interface object name PASS: 8
  MediaStreamTrack interface: attribute enabled PASS: 8
  MediaStreamTrack interface: attribute id PASS: 8
  MediaStreamTrack interface: attribute kind PASS: 8
  MediaStreamTrack interface: attribute label PASS: 8
  MediaStreamTrack interface: attribute muted PASS: 8
  MediaStreamTrack interface: attribute onended PASS: 8
  MediaStreamTrack interface: attribute onmute PASS: 8
  MediaStreamTrack interface: attribute onoverconstrained PASS: 8
  MediaStreamTrack interface: attribute onunmute PASS: 8
  MediaStreamTrack interface: attribute readyState PASS: 8
  MediaStreamTrack interface: existence and properties of interface object PASS: 8
  MediaStreamTrack interface: existence and properties of interface prototype object PASS: 8
  MediaStreamTrack interface: existence and properties of interface prototype object's "constructor" property PASS: 8
  MediaStreamTrack interface: existence and properties of interface prototype object's @@unscopables property PASS: 8
  MediaStreamTrack interface object length PASS: 8
  MediaStreamTrack interface object name PASS: 8
  MediaStreamTrack interface: operation applyConstraints(MediaTrackConstraints) PASS: 8
  MediaStreamTrack interface: operation clone() PASS: 8
  MediaStreamTrack interface: operation getCapabilities() PASS: 8
  MediaStreamTrack interface: operation getConstraints() PASS: 8
  MediaStreamTrack interface: operation getSettings() PASS: 8
  MediaStreamTrack interface: operation stop() PASS: 8
  Navigator interface: attribute mediaDevices PASS: 8
  Navigator interface: operation getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback) PASS: 8
  OverconstrainedErrorEvent interface: attribute error PASS: 8
  OverconstrainedErrorEvent interface: existence and properties of interface object FAIL: 10
PASS: 8
  OverconstrainedErrorEvent interface: existence and properties of interface prototype object FAIL: 10
PASS: 8
  OverconstrainedErrorEvent interface: existence and properties of interface prototype object's "constructor" property PASS: 8
  OverconstrainedErrorEvent interface: existence and properties of interface prototype object's @@unscopables property PASS: 8
  OverconstrainedErrorEvent interface object length FAIL: 8
assert_equals: wrong value for OverconstrainedErrorEvent.length expected 2 but got 1
  OverconstrainedErrorEvent interface object name PASS: 8
  Test MediaDevices.enumerateDevices call and result. Types only. PASS: 8
  Unscopable handled correctly for active property on MediaStream PASS: 8
  Unscopable handled correctly for addTrack(MediaStreamTrack) on MediaStream PASS: 8
  Unscopable handled correctly for applyConstraints(MediaTrackConstraints) on MediaStreamTrack PASS: 8
  Unscopable handled correctly for clone() on MediaStream PASS: 8
  Unscopable handled correctly for clone() on MediaStreamTrack PASS: 8
  Unscopable handled correctly for deviceId property on MediaDeviceInfo PASS: 8
  Unscopable handled correctly for enabled property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for enumerateDevices() on MediaDevices PASS: 8
  Unscopable handled correctly for error property on OverconstrainedErrorEvent PASS: 8
  Unscopable handled correctly for getAudioTracks() on MediaStream PASS: 8
  Unscopable handled correctly for getCapabilities() on InputDeviceInfo PASS: 8
  Unscopable handled correctly for getCapabilities() on MediaStreamTrack PASS: 8
  Unscopable handled correctly for getConstraints() on MediaStreamTrack PASS: 8
  Unscopable handled correctly for getSettings() on MediaStreamTrack PASS: 8
  Unscopable handled correctly for getSupportedConstraints() on MediaDevices PASS: 8
  Unscopable handled correctly for getTrackById(DOMString) on MediaStream PASS: 8
  Unscopable handled correctly for getTracks() on MediaStream PASS: 8
  Unscopable handled correctly for getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback) on Navigator PASS: 8
  Unscopable handled correctly for getUserMedia(MediaStreamConstraints) on MediaDevices PASS: 8
  Unscopable handled correctly for getVideoTracks() on MediaStream PASS: 8
  Unscopable handled correctly for groupId property on MediaDeviceInfo PASS: 8
  Unscopable handled correctly for id property on MediaStream PASS: 8
  Unscopable handled correctly for id property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for kind property on MediaDeviceInfo PASS: 8
  Unscopable handled correctly for kind property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for label property on MediaDeviceInfo PASS: 8
  Unscopable handled correctly for label property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for mediaDevices property on Navigator PASS: 8
  Unscopable handled correctly for muted property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for onaddtrack property on MediaStream PASS: 8
  Unscopable handled correctly for ondevicechange property on MediaDevices PASS: 8
  Unscopable handled correctly for onended property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for onmute property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for onoverconstrained property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for onremovetrack property on MediaStream PASS: 8
  Unscopable handled correctly for onunmute property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for readyState property on MediaStreamTrack PASS: 8
  Unscopable handled correctly for removeTrack(MediaStreamTrack) on MediaStream PASS: 8
  Unscopable handled correctly for stop() on MediaStreamTrack PASS: 8
  Unscopable handled correctly for toJSON() on MediaDeviceInfo PASS: 8
  Unscopable handled correctly for track property on MediaStreamTrackEvent PASS: 8

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-942961 branch 2 times, most recently from be0d234 to 2cb2110 Mar 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-942961 branch from 2cb2110 to 9d13df4 Mar 7, 2018

Introduce InputDeviceInfo interface
InputDeviceInfo extends MediaDeviceInfo and represents audio and video input
devices. These objects are the result of calling MediaDevices.enumerateDevices().
This interface gives access to the capabilities of the input device it represents
via getCapabilities() method which will be implemented in asubsequent CL.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78

Bug: 817769
Change-Id: Ic9a016a05e622ee02b86d567f64c3ed84f0926c3
Reviewed-on: https://chromium-review.googlesource.com/942961
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541772}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-942961 branch from 9d13df4 to 5c860ce Mar 8, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit aaea1a4 into master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-942961 branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.