Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Whitelist supported properties. #9738

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 1, 2018

This patch whitelists all our supported properties. Any property that
is not supported will return a base CSSStyleValue. This ensures that
we don't accidentally produce unexpected results for properties that
we haven't tested it.

We also add a few new properties to support, bringing the total number
of property tests to 50. We also remove support for 'z-index' because
it uses which we don't support yet.

transition-duration is failing tests because we currently convert
ms to seconds when we compute, which is incorrect.

Some paint/layout tests depend on properties that are not whitelisted,
so we've changed them:

  • border-radius -> margin-left
  • align-items -> empty-cell

Bug: 816402
Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
Reviewed-on: https://chromium-review.googlesource.com/942651
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#540397}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 1, 2018

Build PASSED

Started: 2018-03-02 01:40:36
Finished: 2018-03-02 01:50:44

View more information about this build on:

[css-typed-om] Whitelist supported properties.
This patch whitelists all our supported properties. Any property that
is not supported will return a base CSSStyleValue. This ensures that
we don't accidentally produce unexpected results for properties that
we haven't tested it.

We also add a few new properties to support, bringing the total number
of property tests to 50. We also remove support for 'z-index' because
it uses <integers> which we don't support yet.

transition-duration is failing tests because we currently convert
ms to seconds when we compute, which is incorrect.

Some paint/layout tests depend on properties that are not whitelisted,
so we've changed them:
- border-radius -> margin-left
- align-items -> empty-cell

Bug: 816402
Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
Reviewed-on: https://chromium-review.googlesource.com/942651
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540397}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-942651 branch from bb41920 to 4759c3b Mar 2, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 12e0354 into master Mar 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-942651 branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.