Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ServiceWorker: Add WPT to check if CSP sandbox is respected" #9745

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 2, 2018

This reverts commit 4ffad4c407bc6e60b6c2f021a5a26abb8dc438d2.

Reason for revert: New test consistently fails on multiple platforms:

  • external/wpt/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html
  • virtual/navigation-mojo-response/external/wpt/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html

(https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/43786)

Original change's description:

ServiceWorker: Add WPT to check if CSP sandbox is respected

Bug: 771815
Change-Id: I11dc3cf67e3e40465f612f71fc318fd7061b6581
Reviewed-on: https://chromium-review.googlesource.com/915683
Reviewed-by: Matt Falkenhagen falken@chromium.org
Commit-Queue: Makoto Shimazu shimazu@chromium.org
Cr-Commit-Position: refs/heads/master@{#540467}

TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,clamy@chromium.org,shimazu@chromium.org

Change-Id: I30d4c54e78656e473d0c32622b01004122a3be75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771815
Reviewed-on: https://chromium-review.googlesource.com/945828
Reviewed-by: Greg Thompson grt@chromium.org
Commit-Queue: Greg Thompson grt@chromium.org
Cr-Commit-Position: refs/heads/master@{#540484}

Revert "ServiceWorker: Add WPT to check if CSP sandbox is respected"
This reverts commit 4ffad4c407bc6e60b6c2f021a5a26abb8dc438d2.

Reason for revert: New test consistently fails on multiple platforms:

* external/wpt/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html
* virtual/navigation-mojo-response/external/wpt/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html

(https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/43786)

Original change's description:
> ServiceWorker: Add WPT to check if CSP sandbox is respected
>
> Bug: 771815
> Change-Id: I11dc3cf67e3e40465f612f71fc318fd7061b6581
> Reviewed-on: https://chromium-review.googlesource.com/915683
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540467}

TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,clamy@chromium.org,shimazu@chromium.org

Change-Id: I30d4c54e78656e473d0c32622b01004122a3be75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771815
Reviewed-on: https://chromium-review.googlesource.com/945828
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540484}
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-02 10:27:40
Finished: 2018-03-02 10:38:10

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ceb8d5d into master Mar 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-ace9aca718 branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.