Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE] Don't truncate table cell's padding #9747

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 2, 2018

Truncation caused inadequate logical width when padding is like 1.7px.

Bug: 817342
Change-Id: Ibdb76cc528cc7e04801fe65409bb8f60e5ac69a5
Reviewed-on: https://chromium-review.googlesource.com/943827
Commit-Queue: Xianzhu Wang wangxianzhu@chromium.org
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#540991}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-09 15:11:19
Finished: 2018-03-09 15:18:30

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-943827 branch from 02e82c0 to 004c97d Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-943827 branch from 004c97d to 3851f1f Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [PE] Round instead of truncate table cell's padding [PE] Don't truncate table cell's padding Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-943827 branch 2 times, most recently from b9bd65f to 9f63ae0 Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-943827 branch from 9f63ae0 to 2de9c6c Mar 6, 2018

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Mar 8, 2018

@foolip I'm on rotation and I'm trying to fix this PR.

Apparently, the new test needs to link to a spec. Could you suggest one?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 8, 2018

@Hexcles Hexcles force-pushed the chromium-export-cl-943827 branch from 2de9c6c to 737f957 Mar 8, 2018

@foolip

foolip approved these changes Mar 8, 2018

[PE] Don't truncate table cell's padding
Truncation caused inadequate logical width when padding is like 1.7px.

Bug: 817342
Change-Id: Ibdb76cc528cc7e04801fe65409bb8f60e5ac69a5
Reviewed-on: https://chromium-review.googlesource.com/943827
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540991}

@Hexcles Hexcles force-pushed the chromium-export-cl-943827 branch from 737f957 to 04892ad Mar 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 42c98bf into master Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-943827 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.